MLE-24892 Fixing issue with parallel config #1856
Conversation
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with parallel configuration in Jenkins by fixing the agent allocation for parallel stages and updating the ml-gradle plugin to version 6.2-SNAPSHOT to resolve dependency issues.
Key changes:
- Modified ml-gradle plugin loading to use buildscript classpath instead of plugins block
- Updated Jenkins agent configuration to properly allocate agents for parallel stages
- Replaced static sleep delays with
mlWaitTillReadygradle task for more reliable MarkLogic initialization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-app/build.gradle | Changed ml-gradle plugin from plugins block to buildscript dependency to enable use of SNAPSHOT version 6.2 |
| Jenkinsfile | Fixed parallel execution by setting agent to 'none' at pipeline level and explicitly assigning agents to each stage, plus improved MarkLogic initialization reliability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ./gradlew -i mlWaitTillReady | ||
| sleep 3 | ||
| ./gradlew -i mlWaitTillReady |
There was a problem hiding this comment.
Running mlWaitTillReady twice with a 3-second sleep in between suggests uncertainty about initialization completion. If mlWaitTillReady is reliable, a single call should suffice. If not, consider adding timeout/retry logic within the task itself or documenting why two calls are necessary.
| ./gradlew -i mlWaitTillReady | |
| sleep 3 | |
| ./gradlew -i mlWaitTillReady | |
| # Only one call to mlWaitTillReady should be sufficient; see Jenkinsfile for details. | |
| ./gradlew -i mlWaitTillReady |
No description provided.